Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIPQB-85] Use non-id columns for queries #86

Merged
merged 6 commits into from
Feb 23, 2024
Merged

[UIPQB-85] Use non-id columns for queries #86

merged 6 commits into from
Feb 23, 2024

Conversation

ncovercash
Copy link
Member

Jira UIPQB-85

Purpose

We've extended FQL to support using non-ID columns in place of their normal IDs (e.g. vendor_code/vendor_name instead of vendor_id).

This changes the query builder to:

  1. Build queries using these column names instead of the old idColumnName
  2. Handle "legacy" queries which still use vendor_id and map them to vendor_code silently, to be saved upon edit.

Note

The result viewer still shows an incorrect user friendly query for vendor_code and other derived columns, which must be converted on the backend. MODLISTS-85 has been created to fix this.

Copy link

github-actions bot commented Feb 22, 2024

Jest Unit Test Statistics

  1 files  ±  0    9 suites  +1   1m 12s ⏱️ ±0s
76 tests +14  75 ✔️ +14  1 💤 ±0  0 ±0 
78 runs  +14  77 ✔️ +14  1 💤 ±0  0 ±0 

Results for commit 16538a5. ± Comparison against base commit a051eab.

♻️ This comment has been updated with latest results.

Copy link

@ncovercash ncovercash merged commit a010619 into master Feb 23, 2024
5 checks passed
@ncovercash ncovercash deleted the uipqb-85 branch February 23, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants